smiklosovic commented on a change in pull request #1051:
URL: https://github.com/apache/cassandra/pull/1051#discussion_r685923449
##########
File path: src/java/org/apache/cassandra/audit/AuditLogManager.java
##########
@@ -148,6 +167,8 @@ public synchronized void disableAuditLog()
unregisterAsListener();
IAuditLogger oldLogger = auditLogger;
auditLogger = new NoOpAuditLogger(Collections.emptyMap());
+ // when we disable audit logging, we should also reset options so we
return default ones (from cassandra.yml)
+ auditLogOptions = DatabaseDescriptor.getAuditLoggingOptions();
Review comment:
@ekaterinadimitrova2 FQL is returning options from cassandra.yaml when
FQL is disabled (1).
Here I would expect similar behavior, when I disable audit log, it should
return options from cassandra.yaml.
If we want to do this in such a way that it would "persist" these options
from the last time it was enabled, that is something else. I would create new
ticket for this and we would cover both cases at once instead of doing it just
here and then FQL would be inconsistent with audit log behaviour.
As of now, it is explicitly mentioned what they can expect to be returned in
respective nodetool's command description.
(1)
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/fql/FullQueryLogger.java#L123-L145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
