smiklosovic commented on a change in pull request #1051:
URL: https://github.com/apache/cassandra/pull/1051#discussion_r685934718
##########
File path: src/java/org/apache/cassandra/service/StorageServiceMBean.java
##########
@@ -790,8 +790,15 @@ public StageConcurrency(int corePoolSize, int
maximumPoolSize)
/** Clears the history of clients that have connected in the past **/
void clearConnectionHistory();
public void disableAuditLog();
- public void enableAuditLog(String loggerName, Map<String, String>
parameters, String includedKeyspaces, String excludedKeyspaces, String
includedCategories, String excludedCategories, String includedUsers, String
excludedUsers) throws ConfigurationException;
- public void enableAuditLog(String loggerName, String includedKeyspaces,
String excludedKeyspaces, String includedCategories, String excludedCategories,
String includedUsers, String excludedUsers) throws ConfigurationException;
+ public void enableAuditLog(String loggerName, Map<String, String>
parameters, String includedKeyspaces, String excludedKeyspaces, String
includedCategories, String excludedCategories,
+ String includedUsers, String excludedUsers,
Integer maxArchiveRetries, Boolean block, String rollCycle,
+ Long maxLogSize, Integer maxQueueWeight, String
archiveCommand) throws ConfigurationException, IllegalStateException;
+
+ public void enableAuditLog(String loggerName, Map<String, String>
parameters, String includedKeyspaces, String excludedKeyspaces, String
includedCategories, String excludedCategories,
+ String includedUsers, String excludedUsers)
throws ConfigurationException, IllegalStateException;
+
+ public void enableAuditLog(String loggerName, String includedKeyspaces,
String excludedKeyspaces, String includedCategories, String excludedCategories,
+ String includedUsers, String excludedUsers)
throws ConfigurationException, IllegalStateException;
Review comment:
I deprecated methods which are not accepting new configuration options
we are exposing (these low-level ones for bin log as it is done for fql)
I keep them there until the next release, after that I remove these
deprecated methods and I move the ones which left in StorageService to new
AuditLogManagerMBean.
If we want to keep this "deprecation logic" in next release when I am about
to move them to dedicated MBean, I need to actually keep them in StorageService
too as they just can not suddenly "disappear". We should deprecate the methods
we move first and have them in dedicated MBean first. Hence I suspect there
would be little bit of duplication as I do not think that StorageService might
reference some other MBean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
