tatu-at-datastax commented on a change in pull request #1137:
URL: https://github.com/apache/cassandra/pull/1137#discussion_r696185641



##########
File path: src/java/org/apache/cassandra/cql3/Json.java
##########
@@ -42,7 +42,7 @@
      */
     public static String quoteAsJsonString(String s)
     {
-        return new 
String(BufferRecyclers.getJsonStringEncoder().quoteAsString(s));
+        return new String(JsonStringEncoder.getInstance().quoteAsString(s));

Review comment:
       One other thing that might be relevant: depending on timing, we might 
get Jackson 2.12.5 patch, which has one improvement wrt this change:
   
   https://github.com/FasterXML/jackson-core/issues/712
   
   as I plan to publish 2.12.5 relatively soon, due to another unrelated fix.
   Possibly it would get released as soon as upcoming weekend.
   
   I am also curious whether `trunk` is likely to become 4.1, or 5.0 -- I'd 
guess 4.1 at this point?
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to