tatu-at-datastax commented on a change in pull request #1137:
URL: https://github.com/apache/cassandra/pull/1137#discussion_r696717751
##########
File path: src/java/org/apache/cassandra/cql3/Json.java
##########
@@ -42,7 +42,7 @@
*/
public static String quoteAsJsonString(String s)
{
- return new
String(BufferRecyclers.getJsonStringEncoder().quoteAsString(s));
+ return new String(JsonStringEncoder.getInstance().quoteAsString(s));
Review comment:
The main challenge wrt jmh test (which is a good idea otherwise) is that
the implementation between Jackson 2.9 and 2.10 and later differ and I cannot
think of a way to test difference with just, say, Jackson 2.9. Buffer reuse is
based on `ThreadLocal` for 2.9; this is removed from 2.10 but some other things
are changed as well (default size of buffer allocated, I think).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
