michaelsembwever commented on a change in pull request #1137:
URL: https://github.com/apache/cassandra/pull/1137#discussion_r696503280
##########
File path: src/java/org/apache/cassandra/cql3/Json.java
##########
@@ -42,7 +42,7 @@
*/
public static String quoteAsJsonString(String s)
{
- return new
String(BufferRecyclers.getJsonStringEncoder().quoteAsString(s));
+ return new String(JsonStringEncoder.getInstance().quoteAsString(s));
Review comment:
Can we write a simple JMH microbench class to test the performance
difference? That would be enough for me.
Like just a copy of
https://github.com/apache/cassandra/blob/trunk/test/microbench/org/apache/cassandra/test/microbench/AutoBoxingBench.java
(The microbench full run almost works, ref:
https://ci-cassandra.apache.org/view/Cassandra%204.1/job/Cassandra-trunk-microbench/
But they are easy enough to run individually locally, which is needed
anymore for usable results.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
