michaelsembwever commented on a change in pull request #1152:
URL: https://github.com/apache/cassandra/pull/1152#discussion_r697230051
##########
File path: src/java/org/apache/cassandra/service/StorageProxy.java
##########
@@ -2158,12 +2158,36 @@ public static boolean shouldHint(Replica replica)
return false;
}
}
- boolean hintWindowExpired =
Gossiper.instance.getEndpointDowntime(replica.endpoint()) >
DatabaseDescriptor.getMaxHintWindow();
- if (hintWindowExpired)
+
+ InetAddressAndPort endpoint = replica.endpoint();
+
+ int maxHintWindow = DatabaseDescriptor.getMaxHintWindow();
+
+ long endpointDowntime =
Gossiper.instance.getEndpointDowntime(endpoint);
+
+ boolean hintWindowExpired = endpointDowntime > maxHintWindow;
Review comment:
nit: why all the blank lines here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
