michaelsembwever commented on a change in pull request #1152:
URL: https://github.com/apache/cassandra/pull/1152#discussion_r697246808
##########
File path: src/java/org/apache/cassandra/hints/HintsService.java
##########
@@ -390,6 +390,23 @@ public Future transferHints(Supplier<UUID> hostIdSupplier)
return dispatchExecutor.transfer(catalog, hostIdSupplier);
}
+ /**
+ * Get the earliest hint written for a particular node,
+ * @param hostID UUID of the node to check it's hints.
+ * @return Earliest hint as per unix time or Long.MIN_VALUE if hostID is
null
+ */
+ public long getEarliestHintForNode(UUID hostID)
+ {
+ if (hostID == null)
+ return Long.MIN_VALUE;
Review comment:
```suggestion
Preconditions.checkNotNull(hostId);
```
There's no reason to accept a null argument here. And is already being
guarded against here:
https://github.com/apache/cassandra/pull/1152/files#diff-4f6615c703489b87cafd23c0dc5a4edc4af27c33aba172870b30e38a7d8faa1dR2172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
