michaelsembwever commented on a change in pull request #1152:
URL: https://github.com/apache/cassandra/pull/1152#discussion_r697245223
##########
File path: src/java/org/apache/cassandra/hints/HintsBuffer.java
##########
@@ -66,6 +67,7 @@ private HintsBuffer(ByteBuffer slab)
position = new AtomicLong();
offsets = new ConcurrentHashMap<>();
appendOrder = new OpOrder();
+ earliestHintByHost = new ConcurrentHashMap<>();
Review comment:
- how do the `earliestHintByHost` entries get cleared? (and don't we
run the risk of an old entry here forever blocking hints…?)
- how does this impact a 10k node cluster? what's the expected size of the
map, is it bound by the largest RF?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
