maedhroz commented on code in PR #1754:
URL: https://github.com/apache/cassandra/pull/1754#discussion_r931572403
##########
src/java/org/apache/cassandra/config/DataRateSpec.java:
##########
@@ -285,27 +301,12 @@ public IntMebibytesPerSecondBound(double quantity,
DataRateUnit unit)
/**
* Creates a {@code DataRateSpec.IntMebibytesPerSecondBound} of the
specified amount in mebibytes per second.
*
- * @param mebibytesPerSecond where mebibytesPerSecond shouldn't be
bigger than Long.MAX_VALUE-1
+ * @param mebibytesPerSecond where mebibytesPerSecond shouldn't be
bigger than Integer.MAX_VALUE-1
Review Comment:
nitty nit: We call this `max` in the downstream `validateQuantity()`,
although it's actually one more than the max. I know I'm getting pedantic now,
but perhaps we should just pass `Integer.MAX_VALUE - 1` and use `>` :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
