maedhroz commented on code in PR #1754:
URL: https://github.com/apache/cassandra/pull/1754#discussion_r931587759


##########
src/java/org/apache/cassandra/tools/LoaderOptions.java:
##########
@@ -413,15 +413,25 @@ public Builder parseArgs(String cmdArgs[])
                     {
                         throw new ConfigurationException("Invalid value of 
inter_dc_stream_throughput_outbound: " + 
config.inter_dc_stream_throughput_outbound.toString(), false);
                     }
+
+                    if 
(config.entire_sstable_stream_throughput_outbound.toMebibytesPerSecond() >= 
Integer.MAX_VALUE)
+                    {
+                        throw new ConfigurationException("Invalid value of 
entire_sstable_stream_throughput_outbound: " + 
config.entire_sstable_stream_throughput_outbound.toString(), false);

Review Comment:
   nit: Might be helpful to mention that 
`config.entire_sstable_stream_throughput_outbound` is too large rather than 
just invalid? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to