maedhroz commented on code in PR #1754:
URL: https://github.com/apache/cassandra/pull/1754#discussion_r931585222
##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -331,13 +331,13 @@ public MemtableOptions()
@Deprecated
public int max_streaming_retries = 3;
- @Replaces(oldName = "stream_throughput_outbound_megabits_per_sec",
converter = Converters.MEGABITS_TO_MEBIBYTES_PER_SECOND_DATA_RATE, deprecated =
true)
- public volatile DataRateSpec.IntMebibytesPerSecondBound
stream_throughput_outbound = new
DataRateSpec.IntMebibytesPerSecondBound("24MiB/s");
- @Replaces(oldName =
"inter_dc_stream_throughput_outbound_megabits_per_sec", converter =
Converters.MEGABITS_TO_MEBIBYTES_PER_SECOND_DATA_RATE, deprecated = true)
- public volatile DataRateSpec.IntMebibytesPerSecondBound
inter_dc_stream_throughput_outbound = new
DataRateSpec.IntMebibytesPerSecondBound("24MiB/s");
+ @Replaces(oldName = "stream_throughput_outbound_megabits_per_sec",
converter = Converters.MEGABITS_TO_BYTES_PER_SECOND_DATA_RATE, deprecated =
true)
+ public volatile DataRateSpec.LongBytesPerSecondBound
stream_throughput_outbound = new
DataRateSpec.LongBytesPerSecondBound("24MiB/s");
+ @Replaces(oldName =
"inter_dc_stream_throughput_outbound_megabits_per_sec", converter =
Converters.MEGABITS_TO_BYTES_PER_SECOND_DATA_RATE, deprecated = true)
+ public volatile DataRateSpec.LongBytesPerSecondBound
inter_dc_stream_throughput_outbound = new
DataRateSpec.LongBytesPerSecondBound("24MiB/s");
- public volatile DataRateSpec.IntMebibytesPerSecondBound
entire_sstable_stream_throughput_outbound = new
DataRateSpec.IntMebibytesPerSecondBound("24MiB/s");
- public volatile DataRateSpec.IntMebibytesPerSecondBound
entire_sstable_inter_dc_stream_throughput_outbound = new
DataRateSpec.IntMebibytesPerSecondBound("24MiB/s");
+ public volatile DataRateSpec.LongBytesPerSecondBound
entire_sstable_stream_throughput_outbound = new
DataRateSpec.LongBytesPerSecondBound("24MiB/s");
+ public volatile DataRateSpec.LongBytesPerSecondBound
entire_sstable_inter_dc_stream_throughput_outbound = new
DataRateSpec.LongBytesPerSecondBound("24MiB/s");
Review Comment:
So is `IntMebibytesPerSecondBound` now completely unused outside of tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
