maedhroz commented on code in PR #1754:
URL: https://github.com/apache/cassandra/pull/1754#discussion_r931599058
##########
src/java/org/apache/cassandra/db/compaction/CompactionManager.java:
##########
@@ -153,18 +153,18 @@ public CompactionMetrics getMetrics()
*/
public RateLimiter getRateLimiter()
{
- setRate(DatabaseDescriptor.getCompactionThroughputMebibytesPerSec());
+ setRate(DatabaseDescriptor.getCompactionThroughputBytesPerSec());
return compactionRateLimiter;
}
/**
* Sets the rate for the rate limiter. When compaction_throughput is 0 or
node is bootstrapping,
* this sets the rate to Double.MAX_VALUE bytes per second.
- * @param throughPutMiBPerSec throughput to set in MiB/s
+ * @param throughputBytesPerSec throughput to set in B/s
*/
- public void setRate(final double throughPutMiBPerSec)
+ public void setRate(final double throughputBytesPerSec)
Review Comment:
nit: maybe just change this back to `setRate(double throughput)`, ditch the
local `throughput`, and let the doc comment clarify the units?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
