dcapwell commented on code in PR #1799: URL: https://github.com/apache/cassandra/pull/1799#discussion_r951821971
########## .github/pull_request_template.md: ########## @@ -0,0 +1,32 @@ +## Asscociated Issue + +Replace this text with the Jira issue resolved (e.g. CASSANDRA-####) text specifying why this is a trivial patch. + +## Author(s) and Reviewers + +Patch by <author>; reviewed by <reviewer[s]> + +Co-authored-by: author1 <[email protected]>, author2 <[email protected]>, ..., authorN <[email protected]> + +## What the patch does + +Replace this text with a detailed commit paragraph of why and how the change was made and relevant context in a paragraph here + +## Recommendations: + +- Commits should be squashed to remove intermediate development commit messages. +- Key commit messages start with the issue number (CASSANDRA-xxxx) +- if not a trivial change: Review Comment: personally I would prefer we don't have this line and leave figuring out if trivial to the committers, so keep line 20 to 22, and remove the indent. What is trivial for one may not be for another, so defaulting to best practice with committers being able to allow special cases for trivial work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
