Claudenw commented on code in PR #1799: URL: https://github.com/apache/cassandra/pull/1799#discussion_r952369788
########## .github/pull_request_template.md: ########## @@ -0,0 +1,32 @@ +## Asscociated Issue + +Replace this text with the Jira issue resolved (e.g. CASSANDRA-####) or text specifying why this is a trivial patch. + +## Author(s) and Reviewers + +Patch by <author>; reviewed by <reviewer[s]> + +Co-authored-by: First Last <[email protected]><br/> +Co-authored-by: First2 Last2 <[email protected]> + + +## What the patch does + +Replace this text with a detailed commit paragraph of why and how the change was made and relevant context. + +## Recommendations: + +if not a trivial change: + - Jira ticket contains a description of: what is fixed, why it is needed, and what branches to apply it to. + - Tests are included. + - Documentation changes and/or updates are included. + + +## Notice +By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement. + +###References: +* The [Apache Cassandra "Contributing to Cassandra" guide](https://cassandra.apache.org/_/development/index.html) +* The [Apache Cassandra "Working on Documentation" guide](https://cassandra.apache.org/_/development/documentation.html) Review Comment: I think we need to look at this as a possible first point of contact. A new person grabs a ticket, clones the repository, makes a change, submits a pull request. This is the first place the project has an opportunity to introduce the new person to the project standard practices. Providing reference links is a way to do this. Providing deeper links (like the documentation link) is a way to promote contributions in those spaces. For these reasons I think that these 2 links should stay. ########## .github/pull_request_template.md: ########## @@ -0,0 +1,32 @@ +## Asscociated Issue + +Replace this text with the Jira issue resolved (e.g. CASSANDRA-####) or text specifying why this is a trivial patch. + +## Author(s) and Reviewers + +Patch by <author>; reviewed by <reviewer[s]> + +Co-authored-by: First Last <[email protected]><br/> +Co-authored-by: First2 Last2 <[email protected]> + + +## What the patch does + +Replace this text with a detailed commit paragraph of why and how the change was made and relevant context. + +## Recommendations: + +if not a trivial change: + - Jira ticket contains a description of: what is fixed, why it is needed, and what branches to apply it to. + - Tests are included. + - Documentation changes and/or updates are included. + + +## Notice +By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement. + +###References: +* The [Apache Cassandra "Contributing to Cassandra" guide](https://cassandra.apache.org/_/development/index.html) +* The [Apache Cassandra "Working on Documentation" guide](https://cassandra.apache.org/_/development/documentation.html) +* The [Apache Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html). Review Comment: I am not sure about scaring people off but, after checking on the legal stance, it seems that the person merging the pull request is required to have the ICLA and be responsible for the merge. So I am happy to remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
