Claudenw commented on code in PR #1799: URL: https://github.com/apache/cassandra/pull/1799#discussion_r952191300
########## .github/pull_request_template.md: ########## @@ -0,0 +1,32 @@ +## Asscociated Issue + +Replace this text with the Jira issue resolved (e.g. CASSANDRA-####) text specifying why this is a trivial patch. + +## Author(s) and Reviewers + +Patch by <author>; reviewed by <reviewer[s]> + +Co-authored-by: author1 <[email protected]>, author2 <[email protected]>, ..., authorN <[email protected]> + +## What the patch does + +Replace this text with a detailed commit paragraph of why and how the change was made and relevant context in a paragraph here + +## Recommendations: + +- Commits should be squashed to remove intermediate development commit messages. +- Key commit messages start with the issue number (CASSANDRA-xxxx) +- if not a trivial change: Review Comment: While committer is the ultimate authority, the author is making a request. If the author believes it to be trivial the author should state why. If committer agrees then it is trivial. This is the opportunity for the author to make the case that the change is trivial. If the change is trivial then there may not be a JRIA ticket, there should not be documentation changes (unless it is a documentation typo) and there should not be additional testing required. If any of those exist then the change is probably not trivial. See now that the squash comment and the commit messages start with are not appropriate and will remove them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
