josh-mckenzie commented on code in PR #1799: URL: https://github.com/apache/cassandra/pull/1799#discussion_r952566964
########## .github/pull_request_template.md: ########## @@ -0,0 +1,32 @@ +## Asscociated Issue + +Replace this text with the Jira issue resolved (e.g. CASSANDRA-####) or text specifying why this is a trivial patch. + +## Author(s) and Reviewers + +Patch by <author>; reviewed by <reviewer[s]> + +Co-authored-by: First Last <[email protected]><br/> +Co-authored-by: First2 Last2 <[email protected]> + + +## What the patch does + +Replace this text with a detailed commit paragraph of why and how the change was made and relevant context. + +## Recommendations: + +if not a trivial change: + - Jira ticket contains a description of: what is fixed, why it is needed, and what branches to apply it to. + - Tests are included. + - Documentation changes and/or updates are included. + + +## Notice +By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement. + +###References: +* The [Apache Cassandra "Contributing to Cassandra" guide](https://cassandra.apache.org/_/development/index.html) +* The [Apache Cassandra "Working on Documentation" guide](https://cassandra.apache.org/_/development/documentation.html) +* The [Apache Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html). Review Comment: I disagree about this scaring people off. The second paragraph in the referenced page is: > These agreements help us achieve our goal of providing reliable and long-lived software products through collaborative, open-source software development. In all cases, contributors retain full rights to use their original contributions for any other purpose outside of Apache, while providing the ASF and its projects the right to distribute and build upon their work. Which seems completely inclusive and reasonable to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
