Claudenw commented on code in PR #1799: URL: https://github.com/apache/cassandra/pull/1799#discussion_r952390911
########## .github/pull_request_template.md: ########## @@ -0,0 +1,32 @@ +## Asscociated Issue + +Replace this text with the Jira issue resolved (e.g. CASSANDRA-####) or text specifying why this is a trivial patch. + +## Author(s) and Reviewers + +Patch by <author>; reviewed by <reviewer[s]> Review Comment: So this should literally read: ---- <One sentence description, usually Jira title or CHANGES.txt summary> <Optional lengthier description> patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-##### Co-authored-by: Name1 <email1> Co-authored-by: Name2 <email2> ---- What if there is no Jira ticket? What do we put in for a trivial pull? ########## .github/pull_request_template.md: ########## @@ -0,0 +1,32 @@ +## Asscociated Issue + +Replace this text with the Jira issue resolved (e.g. CASSANDRA-####) or text specifying why this is a trivial patch. + +## Author(s) and Reviewers + +Patch by <author>; reviewed by <reviewer[s]> + +Co-authored-by: First Last <[email protected]><br/> +Co-authored-by: First2 Last2 <[email protected]> + + +## What the patch does + +Replace this text with a detailed commit paragraph of why and how the change was made and relevant context. Review Comment: It is not in the commit if the pull request is not a patch. (like this one) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
