dcapwell commented on code in PR #1948:
URL: https://github.com/apache/cassandra/pull/1948#discussion_r1003821360


##########
src/java/org/apache/cassandra/service/accord/AccordKeyspace.java:
##########
@@ -252,7 +255,7 @@ else if (hasStaticChanges)
             else if (hasRegularChanges)
                 return justRegular;
             else
-                throw new IllegalArgumentException();
+                throw new IllegalArgumentException("CommandsForKey 
has_modifications=" + commandsForKey.hasModifications() + ", but no Static or 
Regular columns changed!");

Review Comment:
   this was useful during debugging, but also has the side benefit if we start 
calling when hasModification=false we see clearly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to