dcapwell commented on code in PR #1948:
URL: https://github.com/apache/cassandra/pull/1948#discussion_r1003823883
##########
src/java/org/apache/cassandra/service/accord/AccordKeyspace.java:
##########
@@ -570,12 +553,12 @@ public static AccordCommand
loadCommand(AccordCommandStore commandStore, TxnId t
return command;
}
- private static <T> T deserializeWithVersionOr(UntypedResultSet.Row row,
String dataColumn, String versionColumn, IVersionedSerializer<T> serializer,
Supplier<T> defaultSupplier) throws IOException
+ private static <T> T deserializeWithVersionOr(UntypedResultSet.Row row,
String dataColumn, LocalVersionedSerializer<T> serializer, Supplier<T>
defaultSupplier) throws IOException
{
- if (!row.has(versionColumn))
+ if (!row.has(dataColumn))
Review Comment:
This isn't a regression as `null` writes to data column are no longer a null
but `version:null`, so the data column will exist where it didn't before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
