dcapwell commented on code in PR #1948:
URL: https://github.com/apache/cassandra/pull/1948#discussion_r1009717974
##########
src/java/org/apache/cassandra/service/accord/AccordKeyspace.java:
##########
@@ -433,31 +424,27 @@ public static Mutation getCommandMutation(AccordCommand
command, long timestampM
Row.Builder builder = BTreeRow.unsortedBuilder();
builder.newRow(Clustering.EMPTY);
int nowInSeconds = (int)
TimeUnit.MICROSECONDS.toSeconds(timestampMicros);
- int version = MessagingService.current_version;
- ByteBuffer versionBytes = accessor.valueOf(version);
+
if (command.status.hasModifications())
builder.addCell(live(CommandsColumns.status, timestampMicros,
accessor.valueOf(command.status.get().ordinal())));
if (command.homeKey.hasModifications())
{
Review Comment:
pushed, left statements that are single statements but long and spread cross
multiple lines; example
```
if (command.storedListeners.hasModifications())
{
addStoredSetChanges(builder, CommandsColumns.listeners,
timestampMicros, nowInSeconds,
command.storedListeners,
ListenerProxy::identifier);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
