belliottsmith commented on code in PR #7:
URL: https://github.com/apache/cassandra-accord/pull/7#discussion_r1012676035


##########
accord-core/src/main/java/accord/local/Node.java:
##########
@@ -361,8 +318,7 @@ private <T> void send(Shard shard, Request send, Set<Id> 
alreadyContacted)
 
     public <T> void send(Collection<Id> to, Request send)
     {
-        for (Id dst: to)
-            send(dst, send);
+        to.forEach(dst -> send(dst, send));

Review Comment:
   https://cr.openjdk.java.net/~cslucas/escape-analysis/EscapeAnalysis.html
   
   This seems to corroborate my understanding, though the byte code size limit 
for performing escape analysis is quite small. I wonder if there is an 
annotation or mechanism for asking escape analysis to be performed on a method 
regardless of size.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to