belliottsmith commented on code in PR #7:
URL: https://github.com/apache/cassandra-accord/pull/7#discussion_r1012642346
##########
accord-core/src/main/java/accord/api/Key.java:
##########
@@ -21,10 +21,7 @@
/**
* A routing key for determining which shards are involved in a transaction
*/
-public interface Key extends Comparable<Key>
+public interface Key extends RoutingKey
{
- /**
- * Returns a hash code of a key to support accord internal sharding. Hash
values for equal keys must be equal.
- */
- int routingHash();
+ RoutingKey toRoutingKey();
Review Comment:
This is all made much clearer by `routables` so it may be better to leave
clarifying comments etc until then (also reduce conflicts)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
