belliottsmith commented on code in PR #1951:
URL: https://github.com/apache/cassandra/pull/1951#discussion_r1014219036
##########
src/java/org/apache/cassandra/service/accord/AccordCommandStore.java:
##########
@@ -251,15 +284,51 @@ public void processBlocking(Runnable runnable)
}
@Override
- public <T> Future<T> submit(PreLoadContext loadCtx, Function<? super
CommandStore, T> function)
+ public <T> Future<T> submit(PreLoadContext loadCtx, Function<? super
SafeCommandStore, T> function)
{
AsyncOperation<T> operation = AsyncOperation.create(this, loadCtx,
function);
executor.execute(operation);
return operation;
}
@Override
- public Future<Void> execute(PreLoadContext preLoadContext, Consumer<?
super CommandStore> consumer)
+ public Agent agent()
+ {
+ return agent;
+ }
+
+ @Override
+ public ProgressLog progressLog()
+ {
+ return progressLog;
+ }
+
+ @Override
+ public RangesForEpoch ranges()
+ {
+ return rangesForEpoch;
+ }
+
+ @Override
+ public long latestEpoch()
+ {
+ return time.epoch();
+ }
+
+ @Override
+ public Timestamp maxConflict(Keys keys)
Review Comment:
That's only because we haven't made it any more efficient here. This
_should_ be implementation defined, so a bit of minor duplication for now seems
fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
