belliottsmith commented on code in PR #1951:
URL: https://github.com/apache/cassandra/pull/1951#discussion_r1014220004
##########
src/java/org/apache/cassandra/service/accord/AccordCommandStore.java:
##########
@@ -203,7 +203,10 @@ public Command ifLoaded(TxnId txnId)
{
AccordCommand command = commandCache.getOrNull(txnId);
if (command != null && command.isLoaded())
+ {
+ getContext().commands.add(command);
Review Comment:
In `NotifyWaitingOn` we assume that commands higher up the stack than us are
accessible, but the Context only permits you to access those that are in its
context. I don't want to revisit the Context semantics too much for now, so
this seemed like an acceptable approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
