belliottsmith commented on code in PR #1951:
URL: https://github.com/apache/cassandra/pull/1951#discussion_r1014224789
##########
src/java/org/apache/cassandra/dht/RandomPartitioner.java:
##########
@@ -276,6 +276,14 @@ public Token increaseSlightly()
return new BigIntegerToken(token.add(BigInteger.ONE));
}
+ @Override
+ public Token decreaseSlightly()
+ {
+ if (token.equals(MINIMUM.token))
Review Comment:
True, there seems to be generally inconsistent protections here between
different kinds of token as well. I can try to normalise this if you like -
personally, I think we should throw exceptions in all increase/decrease methods
where we cannot safely do so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
