adelapena commented on code in PR #1984:
URL: https://github.com/apache/cassandra/pull/1984#discussion_r1016889787
##########
.circleci/generate.sh:
##########
@@ -18,7 +18,11 @@
#
BASEDIR=`dirname $0`
-BASE_BRANCH=cassandra-3.11
+
+# Allow the user to set an env variable to control this, but default to our
version branch
+[ -n "${BASE_BRANCH}" ] || {
Review Comment:
Do we have a use case for setting the branch trough a previously set env
var? I think no other options work that way. If we don't have a use case we can
save us the additional complexity of having two ways of setting the branch and
simplify both the help and error messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
