dchenbecker commented on code in PR #1984:
URL: https://github.com/apache/cassandra/pull/1984#discussion_r1016904750


##########
.circleci/generate.sh:
##########
@@ -18,7 +18,11 @@
 #
 
 BASEDIR=`dirname $0`
-BASE_BRANCH=cassandra-3.11
+
+# Allow the user to set an env variable to control this, but default to our 
version branch
+[ -n "${BASE_BRANCH}" ] || {

Review Comment:
   I can remove it. My setup auto-sets env vars for a given work dir, so it's 
one less flag to have to remember to place



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to