adelapena commented on code in PR #1984:
URL: https://github.com/apache/cassandra/pull/1984#discussion_r1017903493
##########
.circleci/generate.sh:
##########
@@ -184,6 +190,14 @@ fi
# add new or modified tests to the sets of tests to be repeated
if (!($all)); then
+ # Sanity check that the referenced branch exists
+ if ! git show ${BASE_BRANCH} -- >&/dev/null; then
+ echo -e "\n\nUnknown base branch: ${BASE_BRANCH}. Unable to detect changed
tests.\n"
+ echo "If you wish to detect changed tests, please use the '-b' flag to
choose existing"
Review Comment:
Since we are making the detection of tests mandatory, I think that the `If
you wish to detect changed tests,` part of the message is not needed anymore,
or it should be rephrased. Also, it should probably be `use the '-b' option`
instead of `please use the '-b' flag`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
