maedhroz commented on code in PR #2049:
URL: https://github.com/apache/cassandra/pull/2049#discussion_r1061903877
##########
src/java/org/apache/cassandra/service/accord/txn/TxnUpdate.java:
##########
@@ -185,6 +178,7 @@ public Write apply(Data data)
return new TxnWrite(updates);
}
+ // Should we serialize the conditionResult?
Review Comment:
If we serialize the result, does that also remove the need for the
`checkCondition()` method below? (i.e. The condition should already have been
applied somewhere and populated...and `null` would mean something went wrong?)
If so, +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
