maedhroz commented on code in PR #2049:
URL: https://github.com/apache/cassandra/pull/2049#discussion_r1061931891
##########
src/java/org/apache/cassandra/cql3/conditions/ColumnCondition.java:
##########
@@ -257,6 +315,55 @@ else if (otherValue == null)
}
return operator.isSatisfiedBy(type, otherValue, value);
}
+
+ void checkForUnsetValues(List<ByteBuffer> values)
Review Comment:
With this in place, do we still need the per-value checks in
`compareWithOperator()`? I think the only thing we're not currently
double-validating is the usage in `TxnCondition#applies()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
