maedhroz commented on code in PR #2049:
URL: https://github.com/apache/cassandra/pull/2049#discussion_r1061944295
##########
src/java/org/apache/cassandra/cql3/conditions/ColumnCondition.java:
##########
@@ -210,13 +230,51 @@ public static ColumnCondition condition(ColumnMetadata
column, FieldIdentifier u
return new UDTFieldCondition(column, udtField, op, terms);
}
+ /*
+ * Don't change or remove entries (and ordinals) or it will break cross
version compatibility
+ * as the ordinals are sent in messages and stored by Accord for in flight
transactions
+ */
Review Comment:
If it's really important, why not just give each kind an explicit
identifier, sort of like what we have in `cql3.Operator`?
```
static BoundKind fromID(int id)
{
switch(id)
{
case 1: return ELEMENT_ACCESS;
case 2: return MULTI_CELL_COLLECTION;
case 3: return MULTI_CELL_UDT;
case 4: return SIMPLE;
case 5: return UDT_FIELD_ACCESS;
default: throw new AssertionError("Identifier " + id + " does not
match a kind!");
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
