Mmuzaf commented on code in PR #2046:
URL: https://github.com/apache/cassandra/pull/2046#discussion_r1062802379
##########
src/java/org/apache/cassandra/gms/FailureDetector.java:
##########
@@ -53,6 +56,7 @@ public class FailureDetector implements IFailureDetector,
FailureDetectorMBean
private static final Logger logger =
LoggerFactory.getLogger(FailureDetector.class);
public static final String MBEAN_NAME =
"org.apache.cassandra.net:type=FailureDetector";
private static final int SAMPLE_SIZE = 1000;
+ private static final long DEFAULT_FD_INITIAL_VALUE_MS =
Gossiper.intervalInMillis * 2;
Review Comment:
In my understanding, `FailureDetector` and `Gossiper` are initialized almost
at the same time because they have the following JMX bean names:
`public static final String MBEAN_NAME =
`"org.apache.cassandra.net:type=Gossiper";`
`public static final String MBEAN_NAME =
"org.apache.cassandra.net:type=FailureDetector";`
But I think you're right in general. These types of pull requests shouldn't
raise any difficult questions when they got reviewed, so let's leave it for
other PRs.
I've removed this constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
