Mmuzaf commented on code in PR #2046:
URL: https://github.com/apache/cassandra/pull/2046#discussion_r1059142495
##########
src/java/org/apache/cassandra/db/ExpirationDateOverflowHandling.java:
##########
@@ -49,7 +51,7 @@
public static ExpirationDateOverflowPolicy policy;
static {
- String policyAsString =
System.getProperty("cassandra.expiration_date_overflow_policy",
ExpirationDateOverflowPolicy.REJECT.name());
+ String policyAsString =
EXPIRATION_DATE_OVERFLOW_POLICY.getString(ExpirationDateOverflowPolicy.REJECT.name());
Review Comment:
Yes, it is possible. However, the `CassandraRelevantProperties` seems to be
widely used (by different modules or applications) thus I think it is better to
avoid adding extra class dependencies to this class. From my understanding, it
will be better to avoid having any defaults in the
`CassandraRelevantProperties`, but this discussion is not for this thread I
think.
I you think we should move it, I'll do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
