Mmuzaf commented on code in PR #2046:
URL: https://github.com/apache/cassandra/pull/2046#discussion_r1059137917


##########
test/unit/org/apache/cassandra/CassandraXMLJUnitResultFormatter.java:
##########
@@ -73,17 +75,17 @@ private static DocumentBuilder getDocumentBuilder() {
         }
     }
 
-    private static final String tag = System.getProperty("cassandra.testtag", 
"");
+    private static final String tag = TEST_CASSANDRA_TESTTAG.getString();
 
     /*
      * Set the property for the test suite name so that log configuration can 
pick it up
      * and log to a file specific to this test suite
      */
     static
     {
-        String command = System.getProperty("sun.java.command");
+        String command = System.getProperty("sun.java.command"); // 
checkstyle: suppress nearby 'blockSystemPropertyUsage'

Review Comment:
   Initially, I was thinking 'what to do with system properties related to 
tests only', but in my final version, I missed moving it.
   
   Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to