belliottsmith commented on code in PR #26:
URL: https://github.com/apache/cassandra-accord/pull/26#discussion_r1093738412
##########
accord-core/src/main/java/accord/coordinate/Propose.java:
##########
@@ -128,12 +131,7 @@ public void onCallbackFailure(Id from, Throwable failure)
callback.accept(null, failure);
}
- private void onAccepted()
- {
- isDone = true;
- Deps deps = Deps.merge(acceptOks, ok -> ok.deps);
- Execute.execute(node, txnId, txn, route, executeAt, deps, callback);
- }
+ abstract void onAccepted();
// A special version for proposing the invalidation of a transaction; only
needs to succeed on one shard
static class Invalidate implements Callback<AcceptReply>
Review Comment:
I don't think so, but happy to be told otherwise. We have a pattern of
ActionX and ActionX.Invalidate - though perhaps this isn't a good pattern
anyway 🤷
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
