belliottsmith commented on code in PR #26:
URL: https://github.com/apache/cassandra-accord/pull/26#discussion_r1093763768
##########
accord-core/src/main/java/accord/primitives/Txn.java:
##########
@@ -53,6 +66,16 @@ public boolean isRead()
return this == Read;
}
+ /**
+ * Note that it is only possible to do this for transactions whose
execution time is not dependent on
+ * others, i.e. where we may safely propose executeAt = txnId
regardless of when it is witnessed by
Review Comment:
It's only possible to "propose deps". I will clean up this comment, to
contain similar text to the other proposed places to explain this distinction.
In this case we're essentially saying that, because this transaction doesn't
actually execute, it doesn't need to agree an `executeAt`, permitting it the
option of instead agreeing some `deps` from the single `PreAccept` round (since
the deps after `PreAccept` are valid for `executeAt=txnId`, but not for
`executeAt>txnId`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
