belliottsmith commented on code in PR #26:
URL: https://github.com/apache/cassandra-accord/pull/26#discussion_r1093761245
##########
accord-core/src/main/java/accord/messages/BeginRecovery.java:
##########
@@ -297,7 +313,7 @@ private static Deps
acceptedStartedBeforeWithoutWitnessing(SafeCommandStore comm
{
try (Deps.Builder builder = Deps.builder())
{
- commandStore.mapReduce(keys, ranges, RorWs, STARTED_BEFORE,
startedBefore, WITHOUT, startedBefore, Accepted, PreCommitted,
+ commandStore.mapReduce(keys, ranges, Any, STARTED_BEFORE,
startedBefore, WITHOUT, startedBefore, Accepted, PreCommitted,
Review Comment:
These collections are used for _invalidation_, not for deps or execution.
We're looking here for the transactions that _invalidate_ us by _not witnessing
us_. For sync points (most importantly exclusive sync points) this is the whole
purpose of durably agreeing Deps - so that we know for sure we have seen all
`TxnId` that can _possibly_ be agreed to execute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
