dcapwell commented on code in PR #2144:
URL: https://github.com/apache/cassandra/pull/2144#discussion_r1106497280
##########
src/java/org/apache/cassandra/service/accord/async/AsyncWriter.java:
##########
@@ -76,35 +71,26 @@ public AsyncWriter(AccordCommandStore commandStore)
this.cfkCache = commandStore.commandsForKeyCache();
}
- private interface StateMutationFunction<K, V extends AccordState<K>>
+ private interface StateMutationFunction<V>
{
- Mutation apply(AccordCommandStore commandStore, V state, long
timestamp);
+ Mutation apply(AccordCommandStore commandStore, V previous, V updated,
long timestamp);
}
- private static <K, V extends AccordState<K>> List<Future<?>>
dispatchWrites(AsyncContext.Group<K, V> ctxGroup,
-
AccordStateCache.Instance<K, V> cache,
-
StateMutationFunction<K, V> mutationFunction,
-
long timestamp,
-
AccordCommandStore commandStore,
-
List<Future<?>> futures,
-
Object callback)
+ private static <K, V extends ImmutableState> List<AsyncChain<Void>>
dispatchWrites(ImmutableMap<K, ContextValue<V>> values,
+
AccordStateCache.Instance<K, V> cache,
+
StateMutationFunction<V> mutationFunction,
+
long timestamp,
+
AccordCommandStore commandStore,
+
List<AsyncChain<Void>> results,
+
Object callback)
Review Comment:
unresolved as I still see the `callback` in the latest commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
