dcapwell commented on code in PR #2144: URL: https://github.com/apache/cassandra/pull/2144#discussion_r1113326307
########## src/java/org/apache/cassandra/service/accord/async/AsyncOperation.java: ########## @@ -30,14 +30,17 @@ import accord.local.CommandStore; import accord.local.PreLoadContext; import accord.local.SafeCommandStore; +import accord.primitives.RoutableKey; import accord.primitives.Seekables; import accord.primitives.TxnId; +import accord.utils.Invariants; +import accord.utils.async.AsyncChains; import org.apache.cassandra.service.accord.AccordCommandStore; -import org.apache.cassandra.service.accord.AccordCommandStore.SafeAccordCommandStore; -import org.apache.cassandra.service.accord.api.PartitionKey; -import org.apache.cassandra.utils.concurrent.AsyncPromise; +import org.apache.cassandra.service.accord.AccordLiveCommand; +import org.apache.cassandra.service.accord.AccordLiveCommandsForKey; +import org.apache.cassandra.service.accord.AccordSafeCommandStore; -public abstract class AsyncOperation<R> extends AsyncPromise<R> implements Runnable, Function<SafeCommandStore, R>, BiConsumer<Object, Throwable> +public abstract class AsyncOperation<R> extends AsyncChains.Head<R> implements Runnable, Function<SafeCommandStore, R> Review Comment: > I don't think we should keep them around forever. I agree it shouldn't be forever, and is not expected to work on reboot... but should a random cache evection cause such listeners to drop? This is a hard semantic to work with, so think we need some solution for this. > I don't think it should be done as part of this ticket. Given this is a bug in the cep-15-accord branch, this branch not fixing this bug is fine. I do think we should have a failing test to highlight this issue though; feel we should not go to trunk without fleshing this out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
