adelapena commented on PR #1891: URL: https://github.com/apache/cassandra/pull/1891#issuecomment-1450050986
I also prefer to keep the conversations open until the reviewer has acknowledged the changes, or at least remained silent for a time. This makes it easy to follow the discussions on the PR and verify if/how the suggestions have been addressed. I also prefer to follow discussions on the PR page over email notification threads because it groups discussions by topic and code context, instead of just chronologically. I also find difficult to distinguish between open and resolved conversations on email notification threads. I also think that keeping the conversations open makes them more visible for additional reviewers. The exception to this are trivial suggestions that are addressed exactly as suggested, such adding an `@Override` annotation, fixing typos, and that kind of nits. IMO those conversations are unlikely to be discussed by the reviewer and thus they can be immediately resolved. So I guess the rule of thumb would be keeping the conversation open if you think the reviewers might want to review the changes or they might have an objection to them. wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
