adelapena commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1127825407
##########
src/java/org/apache/cassandra/db/RangeTombstoneList.java:
##########
@@ -58,12 +58,12 @@ public class RangeTombstoneList implements
Iterable<RangeTombstone>, IMeasurable
private ClusteringBound<?>[] starts;
private ClusteringBound<?>[] ends;
private long[] markedAts;
- private int[] delTimes;
+ private long[] delTimes;
Review Comment:
I'm not sure adding the boolean array doesn't make sense since it would
still save some memory and maybe conversions. But it might well not be a
noticeable impact so I'm not against leaving it as it was.
As for resolving, reviewers cannot resolve conversations, just add a comment
indicating agreement so the assignee can close them. I have left such comments
on most conversations so you can close them.
However I'd keep this particular conversation open for a while, since there
are other reviewers and they might find it interesting. With such a large PR
it's easy to miss things so I think it's good to see what has caught the
attention of other reviewers. I hope it's not too distracting to leave a few
conversations open, specially if you use email notifications for tracking
discussions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
