adelapena commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1128080125
##########
test/unit/org/apache/cassandra/io/sstable/LegacySSTableTest.java:
##########
@@ -637,18 +637,18 @@ public void testGenerateSstables() throws Throwable
File ksDir = new File(LEGACY_SSTABLE_ROOT,
String.format("%s/legacy_tables", BigFormat.latestVersion));
ksDir.tryCreateDirectories();
- copySstablesFromTestData(String.format("legacy_%s_simple",
BigFormat.latestVersion), ksDir);
- copySstablesFromTestData(String.format("legacy_%s_simple_counter",
BigFormat.latestVersion), ksDir);
- copySstablesFromTestData(String.format("legacy_%s_clust",
BigFormat.latestVersion), ksDir);
- copySstablesFromTestData(String.format("legacy_%s_clust_counter",
BigFormat.latestVersion), ksDir);
+ copySstablesFromTestData(String.format("legacy_%s_simple",
BigFormat.latestVersion), ksDir, "legacy_tables");
+ copySstablesFromTestData(String.format("legacy_%s_simple_counter",
BigFormat.latestVersion), ksDir, "legacy_tables");
+ copySstablesFromTestData(String.format("legacy_%s_clust",
BigFormat.latestVersion), ksDir, "legacy_tables");
+ copySstablesFromTestData(String.format("legacy_%s_clust_counter",
BigFormat.latestVersion), ksDir, "legacy_tables");
}
- public static void copySstablesFromTestData(String table, File ksDir)
throws IOException
+ public static void copySstablesFromTestData(String table, File ksDir,
String ks) throws IOException
Review Comment:
Ah, I see, makes sense. For more clarity, we could add to
`CompactionsCQLTest#testCompactionInvalidTombstone` and
`CompactionsCQLTest#testCompactionInvalidPartitionDeletion` a comment saying
`To generate the sstables with corrupted data, run this commented code in some
pre-c14227 branch that allows for negative ldts`.
By the way, I see that the table we are reading,
`negative-ldts-invalid-deletions-test/invalidtombstones` has more two more rows
than what is written by the commented code, so it seems they haven't been
generated only with it, have they? The same happens with
`negative-ldts-invalid-deletions-test//invalid_partition_deletion`. Both tables
contain the rows `(0, 0, 0), (1, 1, 1)` in addition to the tombstone mentioned
in the commented code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
