adelapena commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1129262330
##########
test/unit/org/apache/cassandra/io/sstable/LegacySSTableTest.java:
##########
@@ -637,18 +637,18 @@ public void testGenerateSstables() throws Throwable
File ksDir = new File(LEGACY_SSTABLE_ROOT,
String.format("%s/legacy_tables", BigFormat.latestVersion));
ksDir.tryCreateDirectories();
- copySstablesFromTestData(String.format("legacy_%s_simple",
BigFormat.latestVersion), ksDir);
- copySstablesFromTestData(String.format("legacy_%s_simple_counter",
BigFormat.latestVersion), ksDir);
- copySstablesFromTestData(String.format("legacy_%s_clust",
BigFormat.latestVersion), ksDir);
- copySstablesFromTestData(String.format("legacy_%s_clust_counter",
BigFormat.latestVersion), ksDir);
+ copySstablesFromTestData(String.format("legacy_%s_simple",
BigFormat.latestVersion), ksDir, "legacy_tables");
+ copySstablesFromTestData(String.format("legacy_%s_simple_counter",
BigFormat.latestVersion), ksDir, "legacy_tables");
+ copySstablesFromTestData(String.format("legacy_%s_clust",
BigFormat.latestVersion), ksDir, "legacy_tables");
+ copySstablesFromTestData(String.format("legacy_%s_clust_counter",
BigFormat.latestVersion), ksDir, "legacy_tables");
}
- public static void copySstablesFromTestData(String table, File ksDir)
throws IOException
+ public static void copySstablesFromTestData(String table, File ksDir,
String ks) throws IOException
Review Comment:
> I think the comment you're asking for is there
[already](https://github.com/apache/cassandra/pull/1891/files#diff-dbf9d67e1f6060176920b0d2555d111ef2d0fc0c3c3a0bec8e49c907155194eeR331)?
That link sends me to the global diff of all files, so I'm not sure what
comment you are referring to. If it's [this
one|https://github.com/bereng/cassandra/blob/CASSANDRA-14227-trunk/test/unit/org/apache/cassandra/db/compaction/CompactionsCQLTest.java#L331-L332],
the part that I'd change is explicitly mentioning that the commented code
generates the sstable. As in `To generate the sstables with corrupted data, run
this commented code in some pre-c14227 branch that allows for negative ldts`.
> The 'extra' rows you are seeing are being inserted by the
'[prepare](https://github.com/apache/cassandra/pull/1891/files#diff-dbf9d67e1f6060176920b0d2555d111ef2d0fc0c3c3a0bec8e49c907155194eeR394)()'
methods iiuc.
Oh, right, I missed that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
