smiklosovic commented on code in PR #2199:
URL: https://github.com/apache/cassandra/pull/2199#discussion_r1129962053
##########
test/unit/org/apache/cassandra/config/YamlConfigurationLoaderTest.java:
##########
@@ -169,6 +171,21 @@ public void readThresholdsFromConfig()
assertThat(c.row_index_read_size_fail_threshold).isEqualTo(new
DataStorageSpec.LongBytesBound(1 << 13, KIBIBYTES));
}
+ @Test
+ public void readSSTableCompressionFromConfig()
+ {
+ Config c = load("test/conf/cassandra.yaml");
+
+ assertNotNull(c.sstable_compressor);
+ assertEquals("org.apache.cassandra.io.compress.LZ4Compressor",
c.sstable_compressor.class_name);
+
assertThat(c.sstable_compressor.parameters).containsKey(CompressionParams.CHUNK_LENGTH_IN_KB);
+
assertThat(c.sstable_compressor.parameters).containsKey(CompressionParams.MIN_COMPRESS_RATIO);
+ CompressionParams cp =
CompressionParams.fromParameterizedClass(c.sstable_compressor);
+ assertThat(cp.chunkLength()).isEqualTo(16384 * 1024);
+ assertThat(cp.isEnabled()).isTrue();
+
assertThat(cp.getSstableCompressor()).isInstanceOf(org.apache.cassandra.io.compress.LZ4Compressor.class);
Review Comment:
can not you import `LZ4Compressor` ? why does it have to be in FQCN form?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
