Claudenw commented on code in PR #2199:
URL: https://github.com/apache/cassandra/pull/2199#discussion_r1131325834


##########
src/java/org/apache/cassandra/schema/CompressionParams.java:
##########
@@ -127,11 +119,50 @@ public static CompressionParams fromMap(Map<String, 
String> opts)
         return cp;
     }
 
+    public static CompressionParams fromParameterizedClass(ParameterizedClass 
parameterizedClass)
+    {
+        Map<String, String> options = new 
HashMap<>(parameterizedClass.parameters);
+        options.put( CLASS, parameterizedClass.class_name);
+
+        String sstableCompressionClass;
+
+
+        if (!removeEnabled(options))
+        {
+            sstableCompressionClass = null;
+
+            if (!options.isEmpty())
+                throw new ConfigurationException(format("If the '%s' option is 
set to false no other options must be specified", ENABLED));

Review Comment:
   It was copied from Map<String,String> processing.  However, the entire code 
block has been removed and  functionality moved to `SSTableCompressionOptions` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to