smiklosovic commented on code in PR #2199:
URL: https://github.com/apache/cassandra/pull/2199#discussion_r1129970390
##########
src/java/org/apache/cassandra/schema/CompressionParams.java:
##########
@@ -127,11 +119,50 @@ public static CompressionParams fromMap(Map<String,
String> opts)
return cp;
}
+ public static CompressionParams fromParameterizedClass(ParameterizedClass
parameterizedClass)
+ {
+ Map<String, String> options = new
HashMap<>(parameterizedClass.parameters);
+ options.put( CLASS, parameterizedClass.class_name);
+
+ String sstableCompressionClass;
+
+
+ if (!removeEnabled(options))
+ {
+ sstableCompressionClass = null;
+
+ if (!options.isEmpty())
+ throw new ConfigurationException(format("If the '%s' option is
set to false no other options must be specified", ENABLED));
Review Comment:
this is interesting. I am curious why there is such condition in place. What
is wrong with having parameters in config if the feature is not enabled? This
is common pattern in cassandra.yaml, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
