bereng commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1132006878
##########
test/unit/org/apache/cassandra/utils/streamhist/StreamingTombstoneHistogramBuilderTest.java:
##########
@@ -124,10 +125,8 @@ public void testNumericTypes() throws Exception
builder.update(2);
builder.update(2, Integer.MAX_VALUE); // To check that value overflow
is handled correctly
TombstoneHistogram hist = builder.build();
- Map<Integer, Integer> asMap = asMap(hist);
-
- assertEquals(1, asMap.size());
- assertEquals(Integer.MAX_VALUE, asMap.get(2).intValue());
+ Map<Long, Integer> asMap = asMap(hist);
+ assertEquals(Integer.MAX_VALUE, asMap.get(2l).intValue());
Review Comment:
Ah you see, on mine it reads perfectly well but yes, `L` should be better in
other typographies. Will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]