bereng commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1135031506
##########
src/java/org/apache/cassandra/db/RangeTombstoneList.java:
##########
@@ -146,11 +153,16 @@ public void add(RangeTombstone tombstone)
* This method will be faster if the new tombstone sort after all the
currently existing ones (this is a common use case),
* but it doesn't assume it.
*/
- public void add(ClusteringBound<?> start, ClusteringBound<?> end, long
markedAt, int delTime)
+ public void add(ClusteringBound<?> start, ClusteringBound<?> end, long
markedAt, long delTime)
Review Comment:
Yeah but it's always been public and I don't want to burden any future
callers with the uint conversion burden. I would prefer to leave it?
You also mention it can be private in another comment. I prefer to favor the
original implementation, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
