bereng commented on code in PR #1891:
URL: https://github.com/apache/cassandra/pull/1891#discussion_r1135024386
##########
src/java/org/apache/cassandra/db/rows/Cell.java:
##########
@@ -42,8 +44,15 @@
public abstract class Cell<V> extends ColumnData
{
public static final int NO_TTL = 0;
- public static final int NO_DELETION_TIME = Integer.MAX_VALUE;
- public static final int MAX_DELETION_TIME = Integer.MAX_VALUE - 1;
+ public static final long NO_DELETION_TIME = Long.MAX_VALUE;
+ public static final int NO_DELETION_TIME_UNSIGNED_INTEGER =
CassandraUInt.MAX_VALUE_UINT;
+ public static final long MAX_DELETION_TIME = CassandraUInt.MAX_VALUE_LONG
- 2;
+ public static final int MAX_DELETION_TIME_UNSIGNED_INTEGER =
CassandraUInt.fromLong(MAX_DELETION_TIME);
Review Comment:
I would really prefer to leave it here. Its it's natural place sitting next
to it's equivalent and any future users of the constant will look for it here
in the first place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
