smiklosovic commented on code in PR #2046:
URL: https://github.com/apache/cassandra/pull/2046#discussion_r1158260541
##########
test/unit/org/apache/cassandra/config/YamlConfigurationLoaderTest.java:
##########
@@ -92,13 +97,12 @@ public void withSystemProperties()
// It is possible that we define a common string representation for
these types so they can be written to; this
// is an issue that SettingsTable may need to worry about.
try (WithProperties ignore = new
WithProperties(CONFIG_ALLOW_SYSTEM_PROPERTIES.getKey(), "true",
- SYSTEM_PROPERTY_PREFIX
+ "storage_port", "123",
- SYSTEM_PROPERTY_PREFIX
+ "commitlog_sync", "batch",
- SYSTEM_PROPERTY_PREFIX
+ "seed_provider.class_name", "org.apache.cassandra.locator.SimpleSeedProvider",
-// PROPERTY_PREFIX +
"client_encryption_options.cipher_suites", "[\"FakeCipher\"]",
- SYSTEM_PROPERTY_PREFIX
+ "client_encryption_options.optional", "false",
- SYSTEM_PROPERTY_PREFIX
+ "client_encryption_options.enabled", "true",
- SYSTEM_PROPERTY_PREFIX
+ "doesnotexist", "true"
+
CASSANDRA_SETTINGS_STORAGE_PORT.getKey(), "123",
Review Comment:
nothing against not using properties in CRP for testing purposes only if
they are not related to test infrastructure itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
